Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet): add useExplorer hook #11685

Merged
merged 1 commit into from
Dec 24, 2021
Merged

chore(wallet): add useExplorer hook #11685

merged 1 commit into from
Dec 24, 2021

Conversation

onyb
Copy link
Member

@onyb onyb commented Dec 23, 2021

Resolves brave/brave-browser#20192.

👉 Incidentally, this PR also fixes a bug in #11655 where we used window.open in a panel code, instead of chrome.tabs.create.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

explorer.mov

@onyb onyb requested review from Douglashdaniel, muliswilliam and a team December 23, 2021 11:53
@onyb onyb self-assigned this Dec 23, 2021
@onyb onyb requested a review from bbondy December 23, 2021 15:00
@onyb onyb merged commit 0496fff into master Dec 24, 2021
@onyb onyb deleted the f/wallet/explorer-url branch December 24, 2021 15:39
@onyb onyb added this to the 1.35.x - Nightly milestone Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Reusable GetBlockExplorerUrl Util
2 participants